fixed a few ebnf errors#35
Closed
dwoodlock wants to merge 1 commit intoapache:masterfrom
dwoodlock:ebnf-changes
Closed
fixed a few ebnf errors#35dwoodlock wants to merge 1 commit intoapache:masterfrom dwoodlock:ebnf-changes
dwoodlock wants to merge 1 commit intoapache:masterfrom
dwoodlock:ebnf-changes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well detailed description of the change:
There are a few errors in the sqlpp.ebnf description of the language that I fixed:
The OrdinaryFunctionCall should be able to have no arguments.
There are functions in asterixdb, like current_time(), that don't have any arguments. I changed to the ebnf to allow that.
A duplicate description of the Selection rule.
One contained the ability to use a LetClause and the other didn't. I deleted the one that didn't as asterixdb does support LetClauses.
Case typo in OrderByClause.
The OrderByClause non-terminal was written in 2 different ways: OrderbyClause and OrderByClause. I changed them all to OrderByClause (consistent with GroupByClause)
The non-Terminal "WITH" was used without the quotes.
In 2 rules, the keyword "WITH" was written without the quotes. I added them.
Context of the change
I'm writing a parser generator for sqlpp in flex/bison using this ebnf and I ran into these errors. I'm not sure if this file is used to generate a parser or just as documentation, but I thought it would be useful to fix these.